-
-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Edit existing mealplan meals #2717
feat: Edit existing mealplan meals #2717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comments to try and plug gaps in my knowledge.
I think I'd need to test this briefly to be in a position to approve this - not certain when I'll get to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sorry it took me so long to get back to this @JackBailey. I've given it a brief test as well, and I must say, I like the experience!
What type of PR is this?
What this PR does / why we need it:
To change a meal plan item, from one to another you have to currently delete and re-add the item. This gets a bit tedious, especially if you're using a note rather than a recipe.
It's just a simple click on the item, and that'll open up an altered version of the "create meal" dialogue, pre-filled with the existing meal information. Only graphical changes are the text for the title and confirm button for the dialogue.
Testing
I ran through editing the date, type, note or recipe and ran the
make backend-all
command.