Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Edit existing mealplan meals #2717

Merged
merged 12 commits into from
Jan 24, 2024

Conversation

JackBailey
Copy link
Contributor

What type of PR is this?

  • feature

What this PR does / why we need it:

To change a meal plan item, from one to another you have to currently delete and re-add the item. This gets a bit tedious, especially if you're using a note rather than a recipe.

It's just a simple click on the item, and that'll open up an altered version of the "create meal" dialogue, pre-filled with the existing meal information. Only graphical changes are the text for the title and confirm button for the dialogue.

Testing

I ran through editing the date, type, note or recipe and ran the make backend-all command.

@JackBailey JackBailey changed the title Add functionality to edit existing mealplan item feat: Edit existing mealplan meals Nov 13, 2023
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments to try and plug gaps in my knowledge.
I think I'd need to test this briefly to be in a position to approve this - not certain when I'll get to that.

frontend/components/global/BaseDialog.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Sorry it took me so long to get back to this @JackBailey. I've given it a brief test as well, and I must say, I like the experience!

@boc-the-git boc-the-git enabled auto-merge January 24, 2024 11:16
@boc-the-git boc-the-git merged commit f62feb8 into mealie-recipes:mealie-next Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants