-
-
Notifications
You must be signed in to change notification settings - Fork 879
Add Categories, Tags and Tools to Manage Data Page #2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Categories, Tags and Tools to Manage Data Page #2737
Conversation
I added a fix for the tool This also fixes #2738 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have a few smaller comments
I went in and added/edited items on the new pages and it all works as expected. I ran into a few weird things with the sorting but they aren't new issues, they've been there for a while
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, great work!
What type of PR is this?
What this PR does / why we need it:
The "Manage Data" page was missing some entries. This adds the remaining data items (Categories, Tags & Tools) to the page and equips them with basic read, edit, delete functionality.
Special notes for your reviewer:
While working on this i discovered that tools cannot be created "on Hand". So for now this will not be displayed in data table.Thx to the quick fix by @michael-genson "on Hand" is added to the tool table.
Testing
The tables are a dumbed down version of implementation of the existing version of the manage data page which i used as a template so they should be as stable as the existing implementation.
I tested everything quite extensivly and could not break it.