Skip to content

Add Categories, Tags and Tools to Manage Data Page #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kuchenpirat
Copy link
Collaborator

@Kuchenpirat Kuchenpirat commented Nov 20, 2023

What type of PR is this?

  • feature

What this PR does / why we need it:

The "Manage Data" page was missing some entries. This adds the remaining data items (Categories, Tags & Tools) to the page and equips them with basic read, edit, delete functionality.

Special notes for your reviewer:

While working on this i discovered that tools cannot be created "on Hand". So for now this will not be displayed in data table.
Thx to the quick fix by @michael-genson "on Hand" is added to the tool table.

Testing

The tables are a dumbed down version of implementation of the existing version of the manage data page which i used as a template so they should be as stable as the existing implementation.
I tested everything quite extensivly and could not break it.

@michael-genson
Copy link
Collaborator

michael-genson commented Nov 20, 2023

I added a fix for the tool onHand property not working right from the frontend. You should be able to add it back to your new data management page

This also fixes #2738

@michael-genson michael-genson linked an issue Nov 20, 2023 that may be closed by this pull request
6 tasks
@Kuchenpirat Kuchenpirat marked this pull request as draft November 20, 2023 16:07
@Kuchenpirat Kuchenpirat marked this pull request as ready for review November 20, 2023 16:23
Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a few smaller comments

I went in and added/edited items on the new pages and it all works as expected. I ran into a few weird things with the sorting but they aren't new issues, they've been there for a while

Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, great work!

@michael-genson michael-genson merged commit 63ac21b into mealie-recipes:mealie-next Nov 21, 2023
@Kuchenpirat Kuchenpirat deleted the extend-manage-data-page# branch November 21, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Tools cannot be "on Hand"
2 participants