Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate VSCode Workspace/Dev Container Settings #2749

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup

What this PR does / why we need it:

(REQUIRED)

Recent VSCode changes broke most of our linting settings. They provided a nice migration guide:

https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions

Thankfully we were mostly using the new extensions, we just had some older configurations too.

Which issue(s) this PR fixes:

(REQUIRED)

N/A

Testing

(fill-in or delete this section)

Pretty sure this fixes everything, I played around to check.

michael-genson and others added 3 commits November 22, 2023 17:40
re-formatted structure
removed deprecated linting settings
added pylint extension to replace old linting setting
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd looked at this myself a few weeks back, but didn't have time to focus on it. Glad to see it progressed! :)

@boc-the-git boc-the-git merged commit 1444404 into mealie-recipes:mealie-next Nov 24, 2023
6 checks passed
@michael-genson michael-genson deleted the chore/update-dev-container-settings branch November 24, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants