fix: various alembic migration issues with queries #2773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
could you maybe give my backup a test? |
|
Sure, do you have a link? |
|
Might need to re-upload, GitHub doesn't seem to like it. It also might be too big for GH:
|
michael-genson
changed the title
|
Whelp, your backup broke several things. They seem fixed now, though to be honest I'm not quite sure why. I built the SQL manually and ran some tests locally to make sure data was still intact. I'm going to send over the migrated db on Discord, if you can check to make sure it works that'd be great. |
6 tasks
hay-kot
requested changes
Dec 3, 2023
alembic/versions/2023-09-01-14.55.42_0341b154f79a_added_normalized_unit_and_food_names.py
Outdated
Show resolved
Hide resolved
alembic/versions/2023-09-01-14.55.42_0341b154f79a_added_normalized_unit_and_food_names.py
Outdated
Show resolved
Hide resolved
alembic/versions/2023-09-01-14.55.42_0341b154f79a_added_normalized_unit_and_food_names.py
Outdated
Show resolved
Hide resolved
alembic/versions/2023-10-04-14.29.26_dded3119c1fe_added_unique_constraints.py
Outdated
Show resolved
Hide resolved
alembic/versions/2023-10-04-14.29.26_dded3119c1fe_added_unique_constraints.py
Outdated
Show resolved
Hide resolved
alembic/versions/2023-10-04-14.29.26_dded3119c1fe_added_unique_constraints.py
Outdated
Show resolved
Hide resolved
hay-kot
reviewed
Dec 4, 2023
alembic/versions/2023-09-01-14.55.42_0341b154f79a_added_normalized_unit_and_food_names.py
Show resolved
Hide resolved
|
I had two different sqlite formats in my test data - one had UUIDs with dashes, one didn't. I resolved the ambiguity by changing the select statement to just give me the raw DB value, rather than trying to coerce things. Both of my test dbs were successful with this change |
hay-kot
approved these changes
Dec 6, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Building off of #2760, another issue came up where committing the transaction was executing the faulty SELECT statement. This PR should prevent this by disabling auto refreshes after commits for this session.
Which issue(s) this PR fixes:
(REQUIRED)
Mentioned in #2769
Testing
(fill-in or delete this section)
Pulled a backup from an older version with dupes and confirmed it migrates correctly now.