fix: Shopping List Migration Fails With No Users #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hay-kot
approved these changes
Mar 12, 2024
michael-genson
deleted the
fix/shopping-list-migration-fails-with-no-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
The migration added in #3213 assigns a user to all shopping lists. It tries to assign it to an admin, but falls back to any user if no admin is found. It is possible to reach a scenario where there isn't any user to assign, i.e. when a shopping list exists on a group, but no user belongs to that group.
This PR deletes shopping lists on groups with no users. I decided to delete them since they can't be accessed anyway (you need to log-in with a user that belongs to the group to see the list in the first place).
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3288
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
Tested using the data provided in #3288 which triggered the migration error, and confirmed the shopping list is successfully deleted and a warning is logged.