Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add setting to fix mypy pydantic warning on vs code dev container setup #4292

Merged

Conversation

tjb1982
Copy link
Contributor

@tjb1982 tjb1982 commented Sep 30, 2024

What type of PR is this?

  • bug

What this PR does / why we need it:

Adds a setting for the mypy extension to fix an import error in dev container setup.

Which issue(s) this PR fixes:

N/A

Testing

Manual via vs code under dev container.

@tjb1982 tjb1982 force-pushed the fix/mypy-pydantic-warning branch from b550e24 to da8e91d Compare September 30, 2024 16:10
@Kuchenpirat
Copy link
Collaborator

@tjb1982 can you prefix your title with fix: to have the title linter not fail?

@tjb1982 tjb1982 changed the title add setting to fix mypy pydantic warning on vs code dev container setup fix: add setting to fix mypy pydantic warning on vs code dev container setup Sep 30, 2024
@tjb1982
Copy link
Contributor Author

tjb1982 commented Sep 30, 2024

@tjb1982 can you prefix your title with fix: to have the title linter not fail?

I had to add an empty commit to retrigger it

Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix.
The warning has been around since forever and its pretty nice to have it gone 😊

@Kuchenpirat Kuchenpirat enabled auto-merge (squash) September 30, 2024 16:28
@Kuchenpirat Kuchenpirat merged commit 49a392f into mealie-recipes:mealie-next Sep 30, 2024
13 checks passed
@Kuchenpirat Kuchenpirat changed the title fix: add setting to fix mypy pydantic warning on vs code dev container setup dev: add setting to fix mypy pydantic warning on vs code dev container setup Oct 19, 2024
@Kuchenpirat Kuchenpirat added dev Internal development and removed bugfix labels Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Internal development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants