Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address Ingredients Parser UX overflow issues on mobile #4962

Open
wants to merge 5 commits into
base: mealie-next
Choose a base branch
from

Conversation

CloCkWeRX
Copy link

@CloCkWeRX CloCkWeRX commented Jan 27, 2025

What this PR does / why we need it:

Before

Desktop was ok

image

But mobile cropped error messages if there was more than one or they were long
image

After:
image

image

Which issue(s) this PR fixes:

#4954

Special notes for your reviewer:

This has a slight tradeoff in that the existing call to action ("Create") now relies on the user understanding what the + icon means, unless they hover over and read the title attribute.

The use of flex-wrap also looks a bit stupid, but the alternative was a list group; which looked bad on desktop.

If the CSS framework has a btn-group-vertical on small screens class; I couldnt find it.

Testing

Tested locally, w/Chrome dev tools for mobile UX.

@CloCkWeRX
Copy link
Author

Let me know if this should have a general "errors" or "Add missing" prefix when errors.any?

@CloCkWeRX CloCkWeRX marked this pull request as ready for review January 27, 2025 05:49
Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the concept of this quite a bit but there are still a few things that need improving.

  • I feel like it should be visually possible to determin if the parser wants to create a new food or unit (either swaping the plus icon in the button for the food | icon button or appending an icon that matches the type)
  • We need to add vertical margin so the cards are no longer right against each other.
  • The cards are not all aligned to the right side if they stack which looks quite ugly (screenshot)

image

frontend/pages/g/_groupSlug/r/_slug/ingredient-parser.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants