Fix hard conditions #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for your demo, it's very useful!
I think I found two bugs in the notebook:
sum(y[i][:]) >= 1. Otherwise some items can be unassigned to any cluster which then triggers warnings 'y_... assigned 0 clusters'.I added a test case –
make_blobswith slightly differentn_samplesandcluster_stdwhich triggers both of these issues.I also noticed that the performance in this benchmark strongly depends on the value of
cluster_std: the larger the blobs the harder the task and consequently the longer LP / MaxSAT solvers work.Perhaps, if one is interested in practical applications of these algorithms they could re-run this benchmark with more complex setup.