Refactor: dropzone context #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@4leite is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
chrisvxd
requested changes
Mar 25, 2024
Yeah you had to go and do all that work on the dnd iframe compat! Got a bunch on and then it's Easter, so likely won't get back to this for a couple of weeks. |
|
Closing this until you're ready @4leite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use discriminated union type for DropZoneContext to provide a better typed context.
Facilitates the removal of a bunch of guard clauses and better documents the expected use.
Export DropZoneContext inside useDropZoneContext, useDropZoneEditContext and useDropZoneRenderContext.
Throw error on incorrect mode - we could add an ErrorBoundary to catch this, shouldn't be necessary due to:.
The current behaviour of gracefully showing a message on missing context is retained by moving it to the parent component.