Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't load dnd until client is ready #373

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

chrisvxd
Copy link
Member

@chrisvxd chrisvxd commented Mar 22, 2024

New iframe / viewport features don't play well with server rendering, such as Next.js static builds. This change defers the rendering of dnd behaviour until the client is ready.

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2024 5:29pm
puck-docs ✅ Ready (Inspect) Visit Preview Mar 23, 2024 5:29pm

@chrisvxd chrisvxd force-pushed the fix-iframes-in-static-builds branch from 6be1dd2 to 84a0f42 Compare March 23, 2024 17:27
@chrisvxd chrisvxd merged commit 70cf177 into main Mar 23, 2024
4 checks passed
@chrisvxd chrisvxd deleted the fix-iframes-in-static-builds branch March 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant