Pre release fixes #392
Merged
Pre release fixes #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The esbuild implementation of CSS modules does not provide an obvious way to isolate the styles with a random hash. Instead of names like .Button-abc123, tsup is generating names like .Button, which dramatically increases the risk of collision when consumed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisvxd
force-pushed
the
pre-release-fixes
branch
from
aa6291a to
146eecc
Compare
chrisvxd
force-pushed
the
pre-release-fixes
branch
from
146eecc to
2e7ad5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few final fixes before
v0.14.0release based on canary testing.@4leite I had to revert #359 as the esbuild implementation of CSS modules does not isolate styles using a random hash, only by checking for conflicts with the rest of the bundle. Since we don't know the final bundling environment, we require a random hash to avoid collisions.
i.e. instead of names like
.Button-abc123, tsup (aka esbuild) is generating names like.Button. Perhaps there is a way to address this, but I couldn't see anything when reading the docs, and didn't want to delay the release to debug fully.