-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft/deployment setup #66
Conversation
PS: We setting the SENTRY_DSN in the private story_indexer repo? |
Sure on the ESHOSTS, but the `ui` still references the `api` using the container name `APIURL: http://api:8000/v1`, so I guess retaining a custom defined network rather than using the default docker bridge network provides for better isolation
Containers in the same stack can always reach each other. As long as
the servers where development, staging and production stacks are run
are not in the same swarm cluster, the network name can be static, but
requiring an external network doesn't seem necessary to me.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. While I have remaining issues/questions (which could take an hour to fully write up), it's already taken too long to get to this point, and past experience has shown that in a week it's unlikely to be more than 50% better than the week before.
@kilemensi you can have a final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
This PR creates a workflow to deploy the
news-search-api
separately from thestory-indexer
.Define workflow to deploy to staging & production