add swarm mode, to have multiple api services #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilemensi
reviewed
May 27, 2024
There was a problem hiding this comment.
👍🏽
- Looking at Remove news search api from deploy story-indexer#293,
NEWS_SEARCH_UI_TITLEis missing? (I don't think it needs command line option, env should be enough) - Don't we need to update
docsto reflect the switch swarm mode?
kilemensi
approved these changes
May 27, 2024
philbudne
requested changes
May 27, 2024
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
…earch-api into ft/deploy-api-as-stack
philbudne
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the deployment script to allow deploying multiple replicas of the
News-search-APIservice, therefore introducing Docker swarm deployment from compose