Add new integration tests against MC news-search-api and test ES data #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of wacky CI configurations adds a new test. It checkouts out
news-search-api@main
, uses that to insert test data into an ES instance via Docker, and then runs a smaller set of unit tests to verify results of using this API client work. Why? To help us make sure that this api-client can talk to the api-server as we expect it to in a controlled environment (ie. test ES data). This helps build confidence that we don't muck up a low-level integration, at the expense of adding more tests to maintain... kind of a classic tradeoff. See mediacloud/news-search-api#27 (comment) for more thoughts that led me here.Maybe this won't be useful over time, but it seems useful right now as we are still working to establish production-level build and deployment processes across all these repos. I am going to merge so that I can continue the integration work up the call chain.