Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new integration tests against MC news-search-api and test ES data #17

Merged
merged 9 commits into from
Dec 8, 2023

Conversation

rahulbot
Copy link
Contributor

@rahulbot rahulbot commented Dec 8, 2023

This set of wacky CI configurations adds a new test. It checkouts out news-search-api@main, uses that to insert test data into an ES instance via Docker, and then runs a smaller set of unit tests to verify results of using this API client work. Why? To help us make sure that this api-client can talk to the api-server as we expect it to in a controlled environment (ie. test ES data). This helps build confidence that we don't muck up a low-level integration, at the expense of adding more tests to maintain... kind of a classic tradeoff. See mediacloud/news-search-api#27 (comment) for more thoughts that led me here.

Maybe this won't be useful over time, but it seems useful right now as we are still working to establish production-level build and deployment processes across all these repos. I am going to merge so that I can continue the integration work up the call chain.

@rahulbot rahulbot requested a review from pgulley December 8, 2023 21:23
@rahulbot rahulbot self-assigned this Dec 8, 2023
@rahulbot
Copy link
Contributor Author

rahulbot commented Dec 8, 2023

Merging because the WM integration tests that are failing are ones we aren't surprised by:

  • waybacknews.tests.test_waybacknews.TestMediaCloudCollection.test_domain_and_url_search: we know wildcard URL searching fails
  • waybacknews.tests.test_waybacknews.TestMediaCloudCollection.test_reserved_characters: (same reason)
  • waybacknews.tests.test_waybacknews.TestMediaCloudCollection.test_top_terms: something wrong on IA server

@rahulbot rahulbot merged commit e30be2b into main Dec 8, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant