Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure ffmpeg is installed and do not re-install bun #1591

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

divanshu-go
Copy link
Contributor

PS C:\Users\divan> .\install.ps1
Bun is already installed and meets version requirements

add check before installing bun
Copy link

vercel bot commented Mar 13, 2025

@divanshu-go is attempting to deploy a commit to the louis030195's projects Team on Vercel.

A member of the Team first needs to authorize it.

@tribhuwan-kumar
Copy link
Contributor

it'd be better if there is an self uninstallation thing, maybe in script or in bin

@louis030195

@divanshu-go
Copy link
Contributor Author

@tribhuwan-kumar can you explain what are you saying
is it related to this PR
can you suggest changes

@tribhuwan-kumar
Copy link
Contributor

tribhuwan-kumar commented Mar 13, 2025

rustup self uninstall

something like this!
its not related to this pr, we can implement it in another pr
if @louis030195 wants to

@divanshu-go divanshu-go changed the title do not re-install bun make sure ffmpeg is installed and do not re-install bun Mar 13, 2025
@divanshu-go
Copy link
Contributor Author

@tribhuwan-kumar then you should create a new issue or WIP PR for it
I will be happy to contribute !

Write-Host "The script requires administrative privileges. You will be prompted to allow this action."

Start-Process powershell -Verb RunAs -ArgumentList @"
-NoProfile -ExecutionPolicy Bypass -Command "& {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the reason

image

@louis030195
Copy link
Collaborator

btw ffmpeg should not be installed in powershell thing

we install in rust already

https://github.com/mediar-ai/screenpipe/blob/main/screenpipe-core/src/ffmpeg.rs

@divanshu-go
Copy link
Contributor Author

@louis030195 the version that rust code would install the version the winget will install is same which is the essentials release

the thing users would not wait until rust code use some internal process to install it
also you used debug logs at there when it installs ffmpeg using rust
so users wont know it unless they pass --debug

secondly the desktop app also run screenpipe at its backend thus it will try to install ffmpeg and will also take too much time

neverthless its up to you

@louis030195
Copy link
Collaborator

@louis030195 the version that rust code would install the version the winget will install is same which is the essentials release

the thing users would not wait until rust code use some internal process to install it also you used debug logs at there when it installs ffmpeg using rust so users wont know it unless they pass --debug

secondly the desktop app also run screenpipe at its backend thus it will try to install ffmpeg and will also take too much time

neverthless its up to you

yeah so i tihkn the rust ffmpeg install should display a progress bar or something

and in the UI like onboarding or when we run start_screenpipe we should check the log if there is some form of loading (eg downloading model, ffmpeg, migration, etc. it should parse properly and display a UX feedback on the UI like a progress bar, spinner, something, and maybe write a message like "downloading model, ffmpeg whatever"

@divanshu-go
Copy link
Contributor Author

I think instead of bundling 100mb bun we should bundle ffmpeg
much better cause bun can installed anytime is much faster than installing ffmpeg

Cap software use ffmpeg but they bundle it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants