-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure ffmpeg is installed and do not re-install bun #1591
base: main
Are you sure you want to change the base?
Conversation
divanshu-go
commented
Mar 13, 2025
add check before installing bun
@divanshu-go is attempting to deploy a commit to the louis030195's projects Team on Vercel. A member of the Team first needs to authorize it. |
it'd be better if there is an self uninstallation thing, maybe in script or in bin |
@tribhuwan-kumar can you explain what are you saying |
rustup self uninstall something like this! |
@tribhuwan-kumar then you should create a new issue or WIP PR for it |
Write-Host "The script requires administrative privileges. You will be prompted to allow this action." | ||
|
||
Start-Process powershell -Verb RunAs -ArgumentList @" | ||
-NoProfile -ExecutionPolicy Bypass -Command "& { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw ffmpeg should not be installed in powershell thing we install in rust already https://github.com/mediar-ai/screenpipe/blob/main/screenpipe-core/src/ffmpeg.rs |
@louis030195 the version that rust code would install the version the winget will install is same which is the the thing users would not wait until rust code use some internal process to install it secondly the desktop app also run screenpipe at its backend thus it will try to install ffmpeg and will also take too much time neverthless its up to you |
yeah so i tihkn the rust ffmpeg install should display a progress bar or something and in the UI like onboarding or when we run start_screenpipe we should check the log if there is some form of loading (eg downloading model, ffmpeg, migration, etc. it should parse properly and display a UX feedback on the UI like a progress bar, spinner, something, and maybe write a message like "downloading model, ffmpeg whatever" |
I think instead of bundling 100mb bun we should bundle ffmpeg Cap software use ffmpeg but they bundle it |