-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make screenpipe run on Windows 10 #1592
base: main
Are you sure you want to change the base?
Conversation
hey! thanks for the contribution. would you mind adding more details about: - what problem you're trying to solve - why this change is needed - any relevant context or screenshots |
@divanshu-go is attempting to deploy a commit to the louis030195's projects Team on Vercel. A member of the Team first needs to authorize it. |
@@ -122,7 +122,7 @@ jobs: | |||
fi | |||
sleep 10 | |||
done | |||
echo "runner_type=windows-latest" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our self hosted runner has priority and it's a windows 10 or 11 dont remember (computer at home)
so u mean if we build from windows 11 it wont work on w10? and if built on 10 it will work on 11? what about this issue #1034 #794 #943 which is still not solved i believe cc @tribhuwan-kumar thoughts? |
@louis030195 exactly they dont get to work on normal win10 and some win11 therefore I chose windows-2019 which has a older build but work perfectly on win10 and win11 |
our self hosted runner is windows 11 pro does the build will work on all machine then? |
building on window 10 or if we use |
okay then can you remove the self hosted part altogther (which will make this github action much easier to read) and just use github runner one |
No description provided.