Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make screenpipe run on Windows 10 #1592

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

divanshu-go
Copy link
Contributor

No description provided.

Copy link

request-info bot commented Mar 13, 2025

hey! thanks for the contribution. would you mind adding more details about: - what problem you're trying to solve - why this change is needed - any relevant context or screenshots
this helps us review and merge faster! 🚀

@divanshu-go divanshu-go changed the title make screenpipe run Windows 10 make screenpipe run on Windows 10 Mar 13, 2025
Copy link

vercel bot commented Mar 13, 2025

@divanshu-go is attempting to deploy a commit to the louis030195's projects Team on Vercel.

A member of the Team first needs to authorize it.

@@ -122,7 +122,7 @@ jobs:
fi
sleep 10
done
echo "runner_type=windows-latest" >> $GITHUB_OUTPUT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our self hosted runner has priority and it's a windows 10 or 11 dont remember (computer at home)

@louis030195
Copy link
Collaborator

louis030195 commented Mar 13, 2025

so u mean if we build from windows 11 it wont work on w10? and if built on 10 it will work on 11?

what about this issue #1034 #794 #943 which is still not solved i believe

cc @tribhuwan-kumar thoughts?

@divanshu-go
Copy link
Contributor Author

@louis030195 exactly
the thing is github runners use Windows server 2022 (windows-latest) which is equivalent to insiders builds of window10
while these build works perfectly on window 11 and insider builds of win10

they dont get to work on normal win10 and some win11

therefore I chose windows-2019 which has a older build but work perfectly on win10 and win11

@louis030195
Copy link
Collaborator

our self hosted runner is windows 11 pro

does the build will work on all machine then?

@divanshu-go
Copy link
Contributor Author

divanshu-go commented Mar 13, 2025

building on window 10 or if we use windows-2019 from github hosted runners
then it would work on both window 10 and 11 (pro , home, etc)

@louis030195
Copy link
Collaborator

okay

then can you remove the self hosted part altogther (which will make this github action much easier to read) and just use github runner one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants