Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update configurationmanager to support configuration file name #940

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

codingPF
Copy link
Member

@codingPF codingPF commented Nov 5, 2023

Remove static cralwermanager - was only used in test cases
Pin config in log4jfactory
Avoid building new config instance in some cases
Remove workaround for static crawlermanager in test cases
Restructure main to allow passing configfile to configurationmanager
update test cases and remove some unused imports

Copy link

sonarqubecloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
1.6% 1.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codingPF codingPF merged commit 642bfcb into develop Nov 8, 2023
3 of 4 checks passed
@pidoubleyou pidoubleyou deleted the feature/configfilename branch February 11, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant