Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#9490): sidebar filter container for wide screens #9495

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix(#9490): sidebar filter container for wide screens #9495

merged 2 commits into from
Oct 7, 2024

Conversation

latin-panda
Copy link
Contributor

@latin-panda latin-panda commented Oct 3, 2024 •
edited by github-actions bot
Loading

Description

#9490

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@latin-panda latin-panda changed the title fix(): sidebar filter container for wide screens fix(#9490): sidebar filter container for wide screens Oct 3, 2024
@latin-panda
Copy link
Contributor Author

@tatilepizs, I'm taking your offer to try this on that screen! Phone and smaller desktop should still work fine
Thanks!

tatilepizs
tatilepizs approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@tatilepizs tatilepizs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ✨

sidebarFilterContainerTest.mp4

@latin-panda latin-panda linked an issue Oct 4, 2024 that may be closed by this pull request
Can't edit report on desktop with new UI #9490
Closed
@latin-panda latin-panda merged commit 2ac8970 into master Oct 7, 2024
44 checks passed
@latin-panda latin-panda deleted the fix-display-wide-screens branch October 7, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatilepizs tatilepizs tatilepizs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't edit report on desktop with new UI
2 participants
@latin-panda @tatilepizs