Skip to content

Do a proper install check #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NoXPhasma
Copy link
Contributor

The check for xone being installed will fail, if users have some other modules installed via dkms. For example xpad.

This will make sure that we only check for xone being added to dkms.

@dlundqvist
Copy link

dlundqvist commented Jan 4, 2025

Hmm... I'm not sure what problem this is solving. This is output from Debian testing:

root@neptune:~# dkms status 
v4l2loopback/0.13.2, 6.10.11-amd64, x86_64: installed
v4l2loopback/0.13.2, 6.12.5-amd64, x86_64: installed
v4l2loopback/0.13.2, 6.12.6-amd64, x86_64: installed
xone/v0.3-94-g2be4b81, 6.10.11-amd64, x86_64: installed
xone/v0.3-94-g2be4b81, 6.12.5-amd64, x86_64: installed
xone/v0.3-94-g2be4b81, 6.12.6-amd64, x86_64: installed
root@neptune:~# dkms status xone
xone/v0.3-94-g2be4b81, 6.10.11-amd64, x86_64: installed
xone/v0.3-94-g2be4b81, 6.12.5-amd64, x86_64: installed
xone/v0.3-94-g2be4b81, 6.12.6-amd64, x86_64: installed
root@neptune:~# dkms status v4l2loopback
v4l2loopback/0.13.2, 6.10.11-amd64, x86_64: installed
v4l2loopback/0.13.2, 6.12.5-amd64, x86_64: installed
v4l2loopback/0.13.2, 6.12.6-amd64, x86_64: installed
root@neptune:~# dkms status xpad
root@neptune:~# 

For me dkms status xone only shows any output if xone is installed for any kernel.

@NoXPhasma
Copy link
Contributor Author

NoXPhasma commented Jan 4, 2025

Add xpad to dkms and then dkms status xone will always be positive, even if xone is not installed.

Example from the discord:
grafik

@dlundqvist
Copy link

Is https://github.com/paroj/xpad the one to install?

@NoXPhasma
Copy link
Contributor Author

I'm not sure, possible. I've asked the user who is affected but no answer yet. Couldn't reproduce that with that repository here. It might also be an issue only affecting specific dkms versions.

@dlundqvist
Copy link

I can't reproduce this with xone uninstalled:

root@neptune:~# dkms status
v4l2loopback/0.13.2, 6.10.11-amd64, x86_64: installed
v4l2loopback/0.13.2, 6.12.5-amd64, x86_64: installed
v4l2loopback/0.13.2, 6.12.6-amd64, x86_64: installed
xpad/0.4, 6.12.6-amd64, x86_64: installed
root@neptune:~# dkms status xone
root@neptune:~# dkms status | grep xone
root@neptune:~# 

DKMS version dkms-3.0.13

@NoXPhasma
Copy link
Contributor Author

I'm also unable to reproduce, but this has happened to several people already. Probably a bug in an older dkms version.

@J4ckTh3R1pper
Copy link

I have encountered a failed installation on my machine and when I tried to install again, the script said it's already installed, this is probably the issue.

❯ sudo sh install.sh
Installing xone unknown...
The kernel is built without module signing facility, modules won't be signed
Creating symlink /var/lib/dkms/xone/unknown/source -> /usr/src/xone-unknown

Building module:
Cleaning build area...
Building module(s)...(bad exit status: 2)
Failed command:
make -j12 KERNELRELEASE=6.12.9-1-xanmod1 -C /lib/modules/6.12.9-1-xanmod1/build M=/var/lib/dkms/xone/unknown/build
Error! Bad return status for module build on kernel: 6.12.9-1-xanmod1 (x86_64)
Consult /var/lib/dkms/xone/unknown/build/make.log for more information.
DKMS make.log for xone-unknown for kernel 6.12.9-1-xanmod1 (x86_64)
❯ sudo sh install.sh
Driver is already installed!

@Tweekism
Copy link

This is probably different...

Can you run dkms status xone and post the result?

@J4ckTh3R1pper
Copy link

This is probably different...

Can you run dkms status xone and post the result?

xone/unknown: added, yeah it's a different thing

@Tweekism
Copy link

Did you try running the uninstall script? It should clean that up...

@dlundqvist
Copy link

Is this still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants