Add support for SteelSeries Xbox Headsets #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the vendor ID for SteelSeries ApS 0x1038
My device, the Arctis Nova Pro Wireless, did not work out of the box even with the vendor ID.
The headset.c code assumes that it's safe to call gip_headset_register after receiving the first audio_volume op, seemingly relying on the fact that audio_ready always arrives before it.
In my case the audio_volume arrives before audio_readt and it results in gip_init_audio_out to allocate a 0-byte buffer (client.audio_config_out being not yet initialized).
I'm not sure what is the best way to fix this, for now I've added two flags indicating the receipt of audio_volume and audio_ready and call register only upon receiving both. Feel free to propose a better solution 😉
This is a copy of dlundqvist#25