Bug fix -- BUT NEEDS WORK #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This, along with the newest CMS and newest UniGen fix the underlying issues. BOTH the count and the sampling was wrong. I fixed both. However, I also removed the incorrect system with the "static" sample bag. So this will output a single sample and then die. The original system was 100% wrong, you need to do it better. It outputs a single sample solution right now, but then it dies due to the "static" thing being a giant hack and the way it being architected, it "forgets" the samples, it seems. Or whatever. I have a feeling something is not good with the architecture.
The system SHOULD no longer segfault, as I fixed an issue that could lead to segfault. However, if it does, please let me know how to build statically. Apparently, it only segfaults on static build, so I need to know how and when. In the meanwhile: don't forget that you you HAVE to fix the -fPIC issue as that will affect everyone.
PS: CryptoMiniSat's testing is a bit broken, you have to build with ./build_notest.sh and then it will build.
Mate