Fix multi-line link accessibility paths#1
Draft
meherkasam-square wants to merge 2 commits intomeher/text-linksfrom
Draft
Fix multi-line link accessibility paths#1meherkasam-square wants to merge 2 commits intomeher/text-linksfrom
meherkasam-square wants to merge 2 commits intomeher/text-linksfrom
Conversation
meherkasam-square
force-pushed
the
meher/text-links-2
branch
2 times, most recently
from
82fcb49 to
4b6728f
Compare
meherkasam-square
force-pushed
the
meher/text-links
branch
2 times, most recently
from
6e17438 to
7f0464d
Compare
) This change supports both VoiceOver and Full Keyboard Access through a new consolidated class that refactors the existing `UIAccessibilityElement` code with accommodations for the focus system. ### Demo (tested on an iPad with a hardware keyboard) Note that I activated the call link using the space bar. https://github.com/user-attachments/assets/7ebb3511-1e83-4663-976b-225c34007f80 Additionally, it updates how bounding rectangles are calculated for links so that a more relevant portion of the link is highlighted when it overflows into multiple lines. ### Demo for the bounding rectangles fix #### Before https://github.com/user-attachments/assets/ffdaee0a-d2a2-4e69-b80a-a8016f843653 #### After https://github.com/user-attachments/assets/b5b7ab41-56ff-4dd3-be47-6f3bf7ddb902
meherkasam-square
force-pushed
the
meher/text-links-2
branch
4 times, most recently
from
0f68690 to
011fd88
Compare
meherkasam-square
force-pushed
the
meher/text-links-2
branch
from
011fd88 to
667a81d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.