Skip to content

Commit

Permalink
chore: Move 'marching ants' progress indicator after 'get_notifs' call
Browse files Browse the repository at this point in the history
  • Loading branch information
LangLangBart committed Apr 18, 2024
1 parent f9fa44d commit e380bf2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gh-notify
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,10 @@ print_notifs() {
while :; do
local_page_size=$((total_requested - fetched_count > GH_NOTIFY_PER_PAGE_LIMIT ? \
GH_NOTIFY_PER_PAGE_LIMIT : total_requested - fetched_count))
# "marching ants" because sometimes this takes a bit.
printf >&2 "."
page=$(get_notifs "$page_num") || die "Failed to get notifications."
[[ -z $page ]] && break
# Print "marching ants" after `get_notifs` to indicate progress.
printf >&2 "."

page_num=$((page_num + 1))
# On each run, we can fetch up to 50 notifications. If a user requested 56, we can't specify
Expand Down

0 comments on commit e380bf2

Please sign in to comment.