Skip to content

Replace deprecated publish plugin #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

axelrindle
Copy link
Contributor

Pull Request

Related issue

Fixes #654

What does this PR do?

Replaces the deprecated Gradle Publish Plugin with a new one.

Requires additional testing as I do not possess a Sonatype Account.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@curquiza
Copy link
Member

@axelrindle
Thank you for opening the PR and trying to help us 🙏

I created the v0.11.3 release on this branch, unfortunately, this is still failing:

https://github.com/meilisearch/meilisearch-java/actions/runs/6340371688/job/17221595708?pr=661

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Sep 28, 2023
@axelrindle
Copy link
Contributor Author

Unfortunately I can't really help with this...

But I found some issues that may help:

Could be you need to configure something in Sonatype directly? Or are there other secrets that could be used?

@KaaNee
Copy link
Contributor

KaaNee commented Oct 4, 2023

Have a look at the Background-Tasks of the new plugin, maybe this helps.

https://github.com/gradle-nexus/publish-plugin/#behind-the-scenes
See second point:

creates a retrieve{repository.name.capitalize()}StagingProfile task that retrieves the staging profile id from the remote Nexus repository. This is a diagnostic task to enable setting the configuration property stagingProfileId in nexusPublishing { repositories { myRepository { ... } } }. Specifying the configuration property rather than relying on the API call is considered a performance optimization.

Specify the 'stagingProfileId' if your nexus won't return it on request as explained above (or adapt the nexus config)

@axelrindle
Copy link
Contributor Author

I agree with @KaaNee. Only someone with Nexus/Sonatype access can fix this issue.

@alallema alallema mentioned this pull request Oct 23, 2023
@alallema
Copy link
Contributor

Thank you so much for this PR @axelrindle and for your help @KaaNee 😊

I took the liberty of modifying your PR, I think I've found a solution, probably not the cleanest, but it works if the two tasks are in the same command.
You can check the successful deployment here 🎉

@alallema alallema requested a review from curquiza October 23, 2023 15:56
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you all!

bors merge

@curquiza
Copy link
Member

Issue with bors again... Merging by hand

@curquiza curquiza merged commit 043a7a6 into meilisearch:main Oct 25, 2023
@curquiza curquiza added the enhancement New feature or request label Oct 25, 2023
@axelrindle axelrindle deleted the fix/issue-654 branch October 28, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment is failing due to deprecation of nexus-publish-plugin
4 participants