Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ai powered api changes #687

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Ai powered api changes #687

merged 4 commits into from
Oct 9, 2024

Conversation

ManyTheFish
Copy link
Member

@ManyTheFish ManyTheFish commented Oct 8, 2024 •
edited
Loading

Fix #682

  • Fix broken tests due to the newly mandatory embedder field
  • Add test for embedder settings
  • Change SimilarDocumentsQuery struct:
    • make the embedder field mandatory when constructing the struct
    • remove the setEmbedder method

@ManyTheFish ManyTheFish force-pushed the ai-powered-api-changes branch 7 times, most recently from 2764e14 to bb7df2e Compare October 8, 2024 14:17
@ManyTheFish ManyTheFish marked this pull request as ready for review October 8, 2024 14:32
@norkunas norkunas added enhancement New feature or request breaking-change The related changes are breaking for the users labels Oct 8, 2024
@ManyTheFish @norkunas
Update tests/Settings/EmbeddersTest.php
a812bc1 
Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
@ManyTheFish ManyTheFish merged commit 442a1fa into bump-meilisearch-v1.11.0 Oct 9, 2024
30 checks passed
@ManyTheFish ManyTheFish deleted the ai-powered-api-changes branch October 9, 2024 07:33
@ManyTheFish ManyTheFish mentioned this pull request Oct 9, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas approved these changes

@curquiza curquiza Awaiting requested review from curquiza

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManyTheFish @norkunas