Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ruby 2.6 & Rails 5.2 officially #275

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

brunoocasali
Copy link
Member

  • Deprecate Ruby 2.6 and Ruby on Rails 5.2 (both are EOL since more than 1 year ago).
  • Update meilisearch to 0.25.0

The minimum required version constraint in the gemspec is still 2.6 and will remain like that until we adopt a breaking feature for that version.
This way, we let the use decide when they will be able to move on!

Introduce a change from meilisearch-ruby 0.25.0. That will trigger a warning message when used with camelCase attributes.
Check the release changelog of meilisearch-ruby: https://github.com/meilisearch/meilisearch-ruby/releases/tag/v0.25.0

@brunoocasali brunoocasali added the breaking-change The related changes are breaking for the users label Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (86d6aba) 88.81% compared to head (9854d74) 88.81%.

❗ Current head 9854d74 differs from pull request most recent head 450dc36. Consider uploading reports for the commit 450dc36 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files          10       10           
  Lines         644      644           
=======================================
  Hits          572      572           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brunoocasali brunoocasali merged commit 6f9bcc6 into main Aug 17, 2023
9 checks passed
@brunoocasali brunoocasali deleted the deprecate-rb branch August 17, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants