-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed camel case keywords to snake case #278
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 88.58% 88.58%
=======================================
Files 10 10
Lines 648 648
=======================================
Hits 574 574
Misses 74 74
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this contribution! @jason-hobbs
bors merge 🎉
278: Changed camel case keywords to snake case r=brunoocasali a=jason-hobbs Was getting warnings in tests and logs like so: Non-conforming attributes: searchableAttributes, sortableAttributes Attributes will be expected to be snake_case in future versions of Meilisearch Ruby. Changed all instances of camel case to snake case to make warnings go away and to resolve the deprecations. Co-authored-by: Jason Hobbs <jason.hobbs@hey.com> Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Build failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jason-hobbs (I hope this time the linter will make it through 😅)
bors merge
Build succeeded: |
Was getting warnings in tests and logs like so:
Non-conforming attributes: searchableAttributes, sortableAttributes
Attributes will be expected to be snake_case in future versions of Meilisearch Ruby.
Changed all instances of camel case to snake case to make warnings go away and to resolve the deprecations.