Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed camel case keywords to snake case #278

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

jason-hobbs
Copy link
Contributor

Was getting warnings in tests and logs like so:
Non-conforming attributes: searchableAttributes, sortableAttributes
Attributes will be expected to be snake_case in future versions of Meilisearch Ruby.

Changed all instances of camel case to snake case to make warnings go away and to resolve the deprecations.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3f41be9) 88.58% compared to head (8753e2f) 88.58%.

❗ Current head 8753e2f differs from pull request most recent head d4c6afa. Consider uploading reports for the commit d4c6afa to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files          10       10           
  Lines         648      648           
=======================================
  Hits          574      574           
  Misses         74       74           
Files Changed Coverage Δ
lib/meilisearch-rails.rb 90.36% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brunoocasali
brunoocasali previously approved these changes Sep 5, 2023
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution! @jason-hobbs

bors merge 🎉

meili-bors bot added a commit that referenced this pull request Sep 5, 2023
278: Changed camel case keywords to snake case r=brunoocasali a=jason-hobbs

Was getting warnings in tests and logs like so:
Non-conforming attributes: searchableAttributes, sortableAttributes
Attributes will be expected to be snake_case in future versions of Meilisearch Ruby.

Changed all instances of camel case to snake case to make warnings go away and to resolve the deprecations.

Co-authored-by: Jason Hobbs <jason.hobbs@hey.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 5, 2023

Build failed:

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jason-hobbs (I hope this time the linter will make it through 😅)

bors merge

@meili-bors meili-bors bot merged commit e05271f into meilisearch:main Sep 5, 2023
9 checks passed
@brunoocasali brunoocasali added the enhancement New feature or request label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants