-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix facet search error #320
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 89.09% 89.15% +0.06%
==========================================
Files 10 10
Lines 660 664 +4
==========================================
+ Hits 588 592 +4
Misses 72 72 ☔ View full report in Codecov by Sentry. |
1e6c49b
to
848a508
Compare
848a508
to
38a422e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thanks @ellnix :)
@ellnix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Pull Request
Related issue
Fixes #317
What does this PR do?
Updates SafeIndex to pass**opts
along to methods defined on aMeiliSearch::Index
**options
parameter so to maintain compatibility with it, I created afacet_search
method onSafeIndex