Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facet search error #320

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Feb 8, 2024

Pull Request

Related issue

Fixes #317

What does this PR do?

  • Updates SafeIndex to pass **opts along to methods defined on a MeiliSearch::Index
  • Ruby 2 is different in how it passes the last **options parameter so to maintain compatibility with it, I created a facet_search method on SafeIndex

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a3c04b) 89.09% compared to head (38a422e) 89.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   89.09%   89.15%   +0.06%     
==========================================
  Files          10       10              
  Lines         660      664       +4     
==========================================
+ Hits          588      592       +4     
  Misses         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ellnix ellnix force-pushed the fix-facet-search-error branch 2 times, most recently from 1e6c49b to 848a508 Compare February 8, 2024 13:54
@ellnix ellnix marked this pull request as draft February 8, 2024 14:36
@ellnix ellnix marked this pull request as ready for review February 9, 2024 07:49
@ellnix ellnix requested a review from curquiza February 9, 2024 07:50
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @ellnix :)

@curquiza
Copy link
Member

@ellnix
You can merge when you want, and same, do a new release when you want.
We are available for review

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@brunoocasali
Copy link
Member

Did not see your message before @curquiza haha, I'm going to do this one, then @ellnix can follow do following ones!

@meili-bors meili-bors bot merged commit 53febb3 into meilisearch:main Feb 12, 2024
12 checks passed
@brunoocasali brunoocasali added the bug Something isn't working label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facet search options cannot be passed using SafeIndex
3 participants