Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed soft_deprecate warnings in meilisearch-ruby #372

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

yassun
Copy link
Contributor

@yassun yassun commented Sep 5, 2024

Pull Request

Related issue

N/A

What does this PR do?

  • fixed deprecated warnings from meilisearch-ruby methods.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@ellnix ellnix added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (5b57c6b) to head (48bf7f0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files          13       13           
  Lines         757      757           
=======================================
  Hits          673      673           
  Misses         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@ellnix
Copy link
Collaborator

ellnix commented Sep 13, 2024

bors merge

@meili-bors meili-bors bot merged commit c4abc60 into meilisearch:main Sep 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants