Fix will_paginate crash when Meilisearch disabled #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 88.96% 89.16% +0.20%
==========================================
Files 13 13
Lines 761 766 +5
==========================================
+ Hits 677 683 +6
+ Misses 84 83 -1 ☔ View full report in Codecov by Sentry. |
When Meilisearch is disabled, NullObject is passed to will_paginate when it expects integers.
ellnix
force-pushed
the
will-paginate-disabled-error
branch
from
26e05b8 to
e9cf005
Compare
ellnix
added a commit
to ellnix/meilisearch-rails
that referenced
this pull request
Jan 14, 2025
Using Meilisearch::Rails.active? as an alternative to checking that the objects being replaced are actually. For an alternative solution see meilisearch#383 The advantage of this approach is that NullObject remains opaque, and the logic is much easier to follow (in my opinion).
ellnix
added a commit
to ellnix/meilisearch-rails
that referenced
this pull request
Jan 14, 2025
Using Meilisearch::Rails.active? as an alternative to checking that the objects being replaced are actually NullObject. For an alternative solution see meilisearch#383 The advantage of this approach is that NullObject remains opaque and requires no special treatment, and the logic is much easier to follow (in my opinion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #382
I added a utility method to make the check for NullObject clearer than just testing for
nil?. I'm still not a fan of the solution, I think it would be best if it was behind aMeilisearch::Rails.active?if statement.Please let me know what you think.