Skip to content

Commit

Permalink
Merge #452
Browse files Browse the repository at this point in the history
452: Changes related to the next Meilisearch release (v1.3.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#280

This PR:
- gathers the changes related to the next Meilisearch release (v1.3.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.3.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.3.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
  • Loading branch information
3 people authored Aug 2, 2023
2 parents 74463c1 + e60141c commit 2165bbc
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions spec/meilisearch/index/settings_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -776,15 +776,15 @@ def update_synonyms(index, synonyms)

context 'On faceting' do
let(:index) { client.index(uid) }
let(:faceting) { { maxValuesPerFacet: 333 } }
let(:default_faceting) { { maxValuesPerFacet: 100 } }
let(:faceting) { { maxValuesPerFacet: 333, sortFacetValuesBy: { '*' => 'alpha' } } }
let(:default_faceting) { { maxValuesPerFacet: 100, sortFacetValuesBy: { '*' => 'alpha' } } }

before { client.create_index!(uid) }

it 'gets default values of faceting' do
settings = index.faceting.transform_keys(&:to_sym)

expect(settings).to eq(default_faceting)
expect(settings.keys).to include(*default_faceting.keys)
end

it 'updates faceting' do
Expand All @@ -801,7 +801,7 @@ def update_synonyms(index, synonyms)
update_task = index.update_faceting(nil)
client.wait_for_task(update_task['taskUid'])

expect(index.faceting.transform_keys(&:to_sym)).to eq(default_faceting)
expect(index.faceting.transform_keys(&:to_sym).keys).to include(*default_faceting.keys)
end

it 'resets faceting' do
Expand All @@ -811,7 +811,7 @@ def update_synonyms(index, synonyms)
reset_task = index.reset_faceting
client.wait_for_task(reset_task['taskUid'])

expect(index.faceting.transform_keys(&:to_sym)).to eq(default_faceting)
expect(index.faceting.transform_keys(&:to_sym).keys).to include(*default_faceting.keys)
end
end
end

0 comments on commit 2165bbc

Please sign in to comment.