Skip to content

Commit

Permalink
Merge #106
Browse files Browse the repository at this point in the history
106: Changes about the MeiliSearch's next release (v0.16.0) r=curquiza a=curquiza

Related to this issue: meilisearch/integration-guides#52

- [x] Update README
- [x] Remove `update_health` method 

This PR:
- gathers the changes related to the next release of MeiliSearch (v0.16.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest prerelease of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases). This should be tested locally.
- might eventually fail until the MeiliSearch v0.16.0 is out.

⚠️ This PR should NOT be merged until the MeiliSearch's next release (v0.16.0) is out.

Co-authored-by: Clementine Urquizar <clementine@meilisearch.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
  • Loading branch information
bors[bot] and curquiza authored Nov 4, 2020
2 parents 6cacb78 + 97aa5ec commit 8b4f33a
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 13 deletions.
2 changes: 0 additions & 2 deletions .code-samples.meilisearch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,6 @@ get_indexes_stats_1: |-
client.stats
get_health_1: |-
client.health
update_health_1: |-
client.update_health(false)
get_version_1: |-
client.version
distinct_attribute_guide_1: |-
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ JSON output:

## 🤖 Compatibility with MeiliSearch

This package only guarantees the compatibility with the [version v0.15.0 of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.15.0).
This package only guarantees the compatibility with the [version v0.16.0 of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.16.0).

## 💡 Learn More

Expand Down
4 changes: 0 additions & 4 deletions lib/meilisearch/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ def health
http_get '/health'
end

def update_health(bool)
http_put '/health', health: bool
end

### STATS

def version
Expand Down
6 changes: 0 additions & 6 deletions spec/meilisearch/client/health_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,4 @@
it 'is unhealthy when the url is invalid' do
expect(wrong_client.healthy?).to be false
end

it 'sets unhealthy' do
client.update_health(false)
expect(client.healthy?).to be false
client.update_health(true)
end
end

0 comments on commit 8b4f33a

Please sign in to comment.