Skip to content

Commit

Permalink
Merge #554
Browse files Browse the repository at this point in the history
554: Fix weird error on global SDK CI from meilisearch/meilisearch r=curquiza a=brunoocasali

We use to run a global CI with all the SDKs against the nightly build of meilisearch just to spot any potential error during the development phase of the engine team.

But this time, the error had nothing to do with their implementation; it only involved the ruby CI. The latest run was breaking in a weird way: https://github.com/meilisearch/meilisearch/actions/runs/9941341341/job/27460158817

Somehow, the `time` gem is explicitly required before using some methods like `Time.parse`. I say it is weird because we have the same configuration in this repo, and we don't have that error.

CC: `@ellnix` `@curquiza` 

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
  • Loading branch information
meili-bors[bot] and brunoocasali authored Jul 16, 2024
2 parents 96a2ee4 + 74b8dac commit a293f16
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
matrix:
ruby-version: ['3.1', '3.2', '3.3']
name: integration-tests (ruby ${{ matrix.ruby-version }})
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@

require 'meilisearch'
require 'byebug'
require 'time'

# Globals for all tests
URL = format('http://%<host>s:%<port>s',
Expand Down

0 comments on commit a293f16

Please sign in to comment.