Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix delete documents by filter documentation #536

Merged
merged 1 commit into from
May 23, 2024
Merged

fix delete documents by filter documentation #536

merged 1 commit into from
May 23, 2024

Conversation

the-sinner
Copy link
Contributor

Pull Request

Related issue

Fixes #535

What does this PR do?

  • fixes the delete documents by filter documentation

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@ellnix ellnix added documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs labels May 23, 2024
ellnix
ellnix requested changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! Thanks for taking the time, if you could also add a = in the same commit so that we don't spam the commit history too much.

Thanks again 😄

.code-samples.meilisearch.yaml Outdated
@@ -10,7 +10,7 @@ get_documents_post_1: |-
fields: ['title', 'genres', 'rating', 'language']
)
delete_documents_by_filter_1: |-
client.index('movies').get_documents(filter: 'genres = action OR genres adventure')
client.index('movies').delete_documents(filter: 'genres = action OR genres adventure')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
client.index('movies').delete_documents(filter: 'genres = action OR genres adventure')
client.index('movies').delete_documents(filter: 'genres = action OR genres = adventure')

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be missing an = as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, will do the changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ellnix
ellnix approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellnix
Copy link
Collaborator

ellnix commented May 23, 2024

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented May 23, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit ea3eed8 into meilisearch:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellnix ellnix ellnix approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation on delete documents by filter shows incorrect code
2 participants
@the-sinner @ellnix