Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update httparty requirement from ~> 0.17.1 to >= 0.17.1, < 0.23.0 #538

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 1, 2024

Updates the requirements on httparty to permit the latest version.

Release notes

Sourced from httparty's releases.

v0.22.0

What's Changed

New Contributors

Full Changelog: jnunemaker/httparty@v0.21.0...v0.22.0

Changelog

Sourced from httparty's changelog.

Changelog

All notable changes since 0.22 are documented in GitHub Releases.

0.21.0

0.20.0

Breaking changes

  • Require Ruby >= 2.3.0

Fixes

0.19.1

0.19.0

0.18.1

0.18.0

0.17.3

0.17.2 is broken jnunemaker/httparty#681

0.17.2

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on [httparty](https://github.com/jnunemaker/httparty) to permit the latest version.
- [Release notes](https://github.com/jnunemaker/httparty/releases)
- [Changelog](https://github.com/jnunemaker/httparty/blob/main/Changelog.md)
- [Commits](jnunemaker/httparty@v0.17.1...v0.22.0)

---
updated-dependencies:
- dependency-name: httparty
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file skip-changelog The PR will not appear in the release changelogs labels Jun 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1875bac) to head (d6ad0a8).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #538   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          677       677           
=========================================
  Hits           677       677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curquiza curquiza requested a review from ellnix July 1, 2024 13:28
@bb
Copy link
Contributor

bb commented Jul 2, 2024

I approve this and request it to be merged and released. While meilisearch-ruby 0.27 and earlier allowed httparty from 0.17.1 to (including) 0.21.x, in #531 it was accidentally restricted to 0.17.x with x>=1 for meilisearch 0.28.0.

In the spirit of #530 (comment), the version should be ~> 0.17 which would allow any 0.x. This was also mentioned in 79e6b04#commitcomment-143136367

I already started creating a PR (see commit here: bb@dfbdcc7) but noticed this PR just before submitting mine.

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Jul 9, 2024

@meili-bors meili-bors bot merged commit c88b63a into main Jul 9, 2024
6 checks passed
@meili-bors meili-bors bot deleted the dependabot/bundler/httparty-gte-0.17.1-and-lt-0.23.0 branch July 9, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants