Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require json on top of entry file #564

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

brunoocasali
Copy link
Member

Pull Request

What does this PR do?

In the context of a pure ruby script with no other gem required, this gem will fail in the most straightforward requests like the .version one.

/vendor/bundle/ruby/3.0.0/gems/meilisearch-0.28.2/lib/meilisearch/http_request.rb:120:in `http_config': undefined method `to_json' for nil:NilClass (NoMethodError)
        from /vendor/bundle/ruby/3.0.0/gems/meilisearch-0.28.2/lib/meilisearch/http_request.rb:106:in `send_request'
        from /vendor/bundle/ruby/3.0.0/gems/meilisearch-0.28.2/lib/meilisearch/http_request.rb:26:in `http_get'
        from /vendor/bundle/ruby/3.0.0/gems/meilisearch-0.28.2/lib/meilisearch/client.rb:118:in `version'
        from /app/meilisearch/feed_meilisearch.rb:3:in `feed_meilisearch_with'
        from <internal:prelude>:5:in `irb'
        from /app/meilisearch/feed_meilisearch.rb:7:in `feed_meilisearch_with'
        from /app/meilisearch/feed_meilisearch.rb:49:in `load_data_into_meilisearch'
        from meilisearch/app.rb:26:in `<main>'

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (11fbadf) to head (6b4fa39).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #564   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          684       685    +1     
=========================================
+ Hits           684       685    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brunoocasali
Copy link
Member Author

Thanks @CaroFG for the report :)

@brunoocasali brunoocasali added the bug Something isn't working label Sep 28, 2024
@brunoocasali
Copy link
Member Author

bors merge

Copy link
Contributor

meili-bors bot commented Sep 30, 2024

@meili-bors meili-bors bot merged commit 46f036d into main Sep 30, 2024
8 checks passed
@meili-bors meili-bors bot deleted the brunoocasali-patch-1 branch September 30, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants