Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federated search added #567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Federated search added #567

wants to merge 1 commit into from

Conversation

andre-m-dev
Copy link
Contributor

Pull Request

Related issue

Fixes #558

What does this PR do?

  • Federated search added

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d1c0c19) to head (83a79c8).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #567   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          689       689           
=========================================
  Hits           689       689

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andre-m-dev andre-m-dev changed the title Federated search added Federated search added (#558) Oct 11, 2024
@curquiza curquiza requested a review from ellnix October 14, 2024 09:56
ellnix
ellnix requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Good job on the documentation comment, we should add those for the entire gem.

A few things regarding git:

  • Try to write commit messages in imperative sentences
    Federated search added ❌
    Add federated search ✔️
  • Use git rebase to clean up the git history.

If you are new to git or unsure how to do this, feel free to reach out to me.

spec/meilisearch/client/multi_search_spec.rb
@@ -16,4 +16,19 @@
expect(response['results'][0]['estimatedTotalHits']).to eq(0)
expect(response['results'][1]['estimatedTotalHits']).to eq(0)
end

it 'does a federated search with two different indexes' do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this test is sufficient to see that the server has indeed understood that this is a federated search and not a regular multi-search, there should be separate tests to see if the server returns what you would expect under these circumstances.

In addition we should check that limit and offset are sent properly and work as expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that meet your expectations?

@andre-m-dev andre-m-dev force-pushed the feat/federated-search branch 10 times, most recently from da76a89 to 77ed25b Compare October 30, 2024 00:48
@andre-m-dev
Copy link
Contributor Author

Thanks for the contribution! Good job on the documentation comment, we should add those for the entire gem.

A few things regarding git:

* Try to write commit messages in [imperative sentences](https://www.grammarly.com/blog/sentences/imperative-sentences/)
  `Federated search added` ❌
  `Add federated search` ✔️

* Use git rebase to clean up the git history.

If you are new to git or unsure how to do this, feel free to reach out to me.

Commit message rewritten and git rebase executed

@curquiza curquiza changed the title Federated search added (#558) Federated search added Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellnix ellnix Awaiting requested review from ellnix

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.10.0] Federated search
2 participants
@andre-m-dev @ellnix