Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#250 - Add new Queue domain #251

Merged
merged 1 commit into from
Oct 12, 2023
Merged

#250 - Add new Queue domain #251

merged 1 commit into from
Oct 12, 2023

Conversation

mseaton
Copy link
Collaborator

@mseaton mseaton commented Oct 12, 2023 •
edited by Ruhanga
Loading

@mseaton mseaton requested review from mks-d, Ruhanga and ibacher October 12, 2023 01:16
@mseaton mseaton linked an issue Oct 12, 2023 that may be closed by this pull request
New domain needed for Queue #250
Closed
@mseaton mseaton mentioned this pull request Oct 12, 2023
Closed
Ruhanga
Ruhanga approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mseaton. This LGTM - if this has also been tested against the validator and works fine.

@mseaton mseaton merged commit 1e50b16 into mekomsolutions:master Oct 12, 2023
2 checks passed
@mseaton mseaton deleted the ISSUE-250 branch October 12, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruhanga Ruhanga Ruhanga approved these changes

@mks-d mks-d Awaiting requested review from mks-d

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New domain needed for Queue
2 participants
@mseaton @Ruhanga