feat: add worker api #19
Open
+156
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
reviewed
Aug 5, 2024
| [@mel.get] external origin: t => string = "origin"; | ||
| [@mel.get] external lastEventId: t => string = "lastEventId"; | ||
| [@mel.get] external source: t => [@mel.unwrap] [ | `MessagePort(Dom.messagePort) | `ServiceWorker(Dom.serviceWorker) ] = "source"; | ||
| [@mel.get] external ports: t => Js.Array.t(Dom.messagePort) = "ports"; |
There was a problem hiding this comment.
you can use array instead of Js.Array.t
There was a problem hiding this comment.
Sure, but how is that different? I went to its definition and found out that 'a t = 'a array.
tonyfettes
commented
Aug 5, 2024
|
|
||
| include Webapi__Dom__Types; | ||
|
|
||
| external window: Dom.window = "window"; | ||
| external dedicatedWorkerGlobalScope: Dom.dedicatedWorkerGlobalScope = "self"; |
There was a problem hiding this comment.
@davesnx Is it better to have a globalThis here? Like
external globalThis: 'a = "globalThis"
|
@davesnx can you please re-run the job for me? The upstream PR is merged and I believed these runs can succeed now. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Web Worker DOM bindings.
This PR should be used with PR #1147 in melange.
Fix #18