-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP:color span added. #27
base: master
Are you sure you want to change the base?
Conversation
… of four integers corresponding to ARGB.
@pulyaevskiy I am trying to make this editor support all the other smaller spans . Check for it's correctness and merge this if possible. A chat on gitter will also do. |
Thanks for the PR! Just wanted to note that I’m currently traveling and it’ll take some time for me to review this changes. I should be able to get back on this later next week. |
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
======================================
Coverage ? 90%
======================================
Files ? 3
Lines ? 40
Branches ? 0
======================================
Hits ? 36
Misses ? 4
Partials ? 0 Continue to review full report at Codecov.
|
Hey, sorry I missed this PR. It looks rather unfinished at this point. Are you still planning on pushing more changes? |
3 similar comments
Hey, sorry I missed this PR. It looks rather unfinished at this point. Are you still planning on pushing more changes? |
Hey, sorry I missed this PR. It looks rather unfinished at this point. Are you still planning on pushing more changes? |
Hey, sorry I missed this PR. It looks rather unfinished at this point. Are you still planning on pushing more changes? |
Hi, @pulyaevskiy Sorry that,I wont be able to take this up until next month. Stuck up with some work. And by the what is else is left in this PR except UI for color span and unit tests? |
The key for the span is "c" and the value is a list of four integers corresponding to ARGB.