-
Notifications
You must be signed in to change notification settings - Fork 62
[WC-2946] Initial setup of skiplink widget #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HedwigAR
wants to merge
16
commits into
main
Choose a base branch
from
wc-2946-new-skiplink-widget
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0791c5 to
6bec63d
Compare
e314e29 to
3d6e3f9
Compare
a974d49 to
e73e93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
This PR contains a new skiplink widget, which is necessary for SC 2.4.1: Bypass Blocks .
The point of this widget is for the user to either give the ID of the main content, or to have a main tag on the page. When tabbing through the page, this widget should appear. When the user activates a link the focus should switch to the main content, skipping over repeating elements (such as the menu for example). This makes navigating the page through only keyboard easier.
What should be covered while testing?
Since this is a new widget, basically everything needs to be tested. This widget does only need to work in Mendix 11, since the option to not have auto focus on the page was introduced there.
The only thing that can't be tested yet is the design, since that's part of another story.
Expectations of this widget: