[WC-3146] Improve virtual scrolling in data grid 2 #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix / New feature
Description
With recent improvements of virtual scrolling we introduced an issue with horizontal scroll where vertical scrollbar goes out of sight. To mitigate this we took a new approach and improved vertical scrolling even more. This gives the users ability scroll in both directions and have more natural look and feel when virtual scrolling is enabled.
As a small feature we introduced shadows when the grid is scrolled, so the users immediately see that the grid is in the middle of the scroll, this is a good QoL improvement.
What should be covered while testing?