fix(datagrid-web): virtual scroll loses scrollbar after column hide#2167
Open
rahmanunver wants to merge 2 commits intomainfrom
Open
fix(datagrid-web): virtual scroll loses scrollbar after column hide#2167rahmanunver wants to merge 2 commits intomainfrom
rahmanunver wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix
Description
What:
lockGridBodyHeight()inGridSizeStorelocked the virtual scroll body height once and only reset it when the page size changed. When a column is hidden, row heights can decrease (text no longer wraps), so the content height drops below the lockedmax-height— the scrollbar disappears.Why: The reset condition was incomplete. The existing
lockedAtPageSizeguard pattern was correct but not applied to column-count changes. The fix adds a parallellockedAtColumnCountguard: the locked height is now invalidated whenever the visible column count changes, mirroring the existing page-size reset exactly.Files changed:
src/model/stores/GridSize.store.ts— addedlockedAtColumnCountguardsrc/model/containers/Datagrid.container.ts— wiredvisibleColumnsCountAtomintoGridSizeStorevia DIsrc/components/Pagination.tsx,src/components/WidgetFooter.tsx— pre-existing TS7006 implicit-any fixes (were already failing onmain)e2e/DataGrid.spec.js— regression test: virtual scroll + column hideAGENTS.md— architecture reference for the datagrid-web packageWhat should be covered while testing?