Skip to content

Exclude ListView search elements from auto-close #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Exclude ListView search elements from auto-close #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/DropdownDivConverter/widget/DropdownDivConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,16 @@ define([
// Mendix buttons and links stop events from bubbling: set actions for internal button clicks to close the menu if needed
if (this.autoClose){
this.connect(this.dropdownMenu, "click", lang.hitch(this,function(e){
if (this._isOpen) {
if (this._isOpen && !this._isListViewSearchItem(e.srcElement)) {
this._toggleMenu();
}
}));

var internalButtons = domQuery("button, a", this.dropdownMenu);
dojoArray.forEach(internalButtons, lang.hitch(this,function(node){
var listViewExcluded = dojoArray.filter(internalButtons, lang.hitch(this, function(item) {
return !this._isListViewSearchItem(item);
}));
dojoArray.forEach(listViewExcluded, lang.hitch(this,function(node){
this.connect(node, "click", lang.hitch(this, function(e) {
if (this._isOpen){
this._toggleMenu();
Expand Down Expand Up @@ -302,8 +305,14 @@ define([
if (cb && typeof cb === "function") {
cb();
}
},

_isListViewSearchItem: function(element) {
return domQuery(element).parents(".mx-listview-searchbar").length > 0
}

});
});

require(["DropdownDivConverter/widget/DropdownDivConverter"]);

Binary file modified test/widgets/DropdownDivConverter.mpk
View file
Open in desktop
Binary file not shown.