Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Update documentation and update links #15

Closed
wants to merge 2 commits into from
Closed

Conversation

showierdata9978
Copy link
Member

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Aug 16, 2024

Deploying meower-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ee759c7
Status: ✅  Deploy successful!
Preview URL: https://d32b7c27.meower-docs.pages.dev
Branch Preview URL: https://showier-update.meower-docs.pages.dev

View logs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this file? Shouldn't this documentation be for the Meower API, not the features Meower has?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other place to put it in the docs. Its could be considered a semi index for where stuff is as it gets documented

Copy link
Contributor

@mybearworld mybearworld Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of it in the first place, though? How does it make the documentation better? People reading the Meower docs probably already know which features Meower has

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the client requirements where the only place it existed before. So it needs to be here instead. This is especially needed for new client devs that cant read python/golang

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it needs to be here instead. This is especially needed for new client devs that cant read python/golang

Meower Svelte and others exist. People can see the features Meower has from there. Specific implementation details (i.e. API endpoints) is what the docs would be for

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but that still requires reading source code. It's slightly better to have them listed out somewhere

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listing the API endpoints is the entire point of the docs, doesn't need its own file

| mod_deleted | boolean | Whether the post was deleted by a moderator. | ✓ |
| deleted_at | integer | The post's deletion timestamp in Unix seconds. | ✓ |
<!-- deno-fmt-ignore-start --> <!-- Uploads was down -->
| Field | Type | Description | Optional |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be formatted the way all the other tables are?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's unreadable and uneditable otherwise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How? Also, that's what the rest of the tables do, it should really be consistent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to format it with a vscode ext so I could actually edit it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(tried to do it with 1 other but the ext failed to format that one)

Copy link
Contributor

@mybearworld mybearworld Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't see what you mean

"Formatted"
image

Current
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh wraps lines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meaning it looks worse with line wrapping because it adds an extra line inbetween lines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even without word wrapping (but especially with word wrapping which is pretty much necessary for md files), the current is way easier to read and has more information on screen

"Formatted"
image

"Current"
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no reason for this, especially if you're not adding it to the sidebar. the api reference (/api/rest) should be sufficient once the openapi schema is updated to have actual descriptions and names for the endpoints

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the openapi schema is updated to have actual descriptions and names for the endpoints

Is this planned? That would leave the REST-API section pretty much useless

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this planned? That would leave the REST-API section pretty much useless

yes. we'd like to eventually improve the autogenerated documentation, but there're limitations w/what we can have them display which would probably keep the handwritten docs around

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was very overwhelming tbf

Comment on lines +5 to +14
<!-- deno-fmt-ignore-start -->

| Field | Type | Description |
| - | - | - |
| _id | string | The emoji's UUID4. |
| animated | boolean | Whether the emoji is animated. |
| chat_id | UUID4 | The chat's UUID4. |
| name | string | The emoji's name. |

<!-- deno-fmt-ignore-end -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- deno-fmt-ignore-start -->
| Field | Type | Description |
| - | - | - |
| _id | string | The emoji's UUID4. |
| animated | boolean | Whether the emoji is animated. |
| chat_id | UUID4 | The chat's UUID4. |
| name | string | The emoji's name. |
<!-- deno-fmt-ignore-end -->
<!-- deno-fmt-ignore-start -->
| Field | Type | Description |
| - | - | - |
| _id | string | The emoji's UUID4. |
| animated | boolean | Whether the emoji is animated. |
| chat_id | UUID4 | The chat's UUID4. |
| name | string | The emoji's name. |
<!-- deno-fmt-ignore-end -->

please be consistent w/formatting the ignore blocks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change table formatting to match the other existing files and remove the comment about uploads being down

}
```

#### Livechat
#### Livechat (outdated)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this and the other instances of things being marked as outdated, could you please actually update the examples

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants