linting fixes modules

meraki · Jan 8, 2025 · eab975b · eab975b
1 parent 35d61b0
commit eab975b
Show file tree

Hide file tree

Showing 22 changed files with 30 additions and 74 deletions.
diff --git a/README.md b/README.md
@@ -32,7 +32,8 @@ meraki_server
 Create a playbook `who_am_i.yml` ([example](https://github.com/meraki/dashboard-api-ansible/blob/main/playbooks/who_am_i.yml)):
 ```
 ---
-- hosts: meraki_servers
+- name: Play Name
+  hosts: meraki_servers
   gather_facts: false
   tasks:
     - name: Get my administered identities

diff --git a/playbooks/Get_AP_Serials.yaml b/playbooks/Get_AP_Serials.yaml
@@ -11,7 +11,7 @@
         total_pages: -1
       register: result
     - name: Filter APs with "wireless" productTypes and get Serial Number
-      set_fact:
+      ansible.builtin.set_fact:
         filtered_aps: '{{ result.meraki_response | selectattr(''productType'', ''contains'',
           ''wireless'') | map(attribute=''serial'') | list }}'
       register: aps

diff --git a/playbooks/What_Org.yaml b/playbooks/What_Org.yaml
@@ -1,4 +1,5 @@
-- hosts: meraki_servers
+- name: Play Name
+  hosts: meraki_servers
   gather_facts: false
   tasks:
     - name: Get all Organizations

diff --git a/playbooks/Who_Am_I.yaml b/playbooks/Who_Am_I.yaml
@@ -1,4 +1,5 @@
-- hosts: meraki_servers
+- name: Play Name
+  hosts: meraki_servers
   gather_facts: false
   tasks:
     - name: Get my administered identities

diff --git a/playbooks/credentials.yml b/playbooks/credentials.yml
diff --git a/playbooks/devices.yaml b/playbooks/devices.yaml
diff --git a/playbooks/devices.yml b/playbooks/devices.yml
@@ -2,7 +2,7 @@
   hosts: localhost
   gather_facts: false
   tasks:
-    - name: change name of device
+    - name: Change name of device
       cisco.meraki.devices:
         name: new name 12
         serial: QBSC-ALSL-3GXN

diff --git a/playbooks/old_collection_test.yml b/playbooks/old_collection_test.yml
diff --git a/playbooks/organizations_login_security.yml b/playbooks/organizations_login_security.yml
@@ -1,7 +1,6 @@
 - name: Play Name
   hosts: localhost
   vars:
-    vars: null
     org_id: 828099381482762270
   gather_facts: false
   tasks:

diff --git a/playbooks/switch_port_config.yml b/playbooks/switch_port_config.yml
@@ -2,7 +2,7 @@
   hosts: localhost
   gather_facts: false
   tasks:
-    - name: update ports
+    - name: Update ports
       cisco.meraki.devices_switch_ports:
         meraki_suppress_logging: true
         state: present

diff --git a/playbooks/who_am_i.yml b/playbooks/who_am_i.yml
@@ -1,4 +1,5 @@
-- hosts: meraki_servers
+- name: Play Name
+  hosts: meraki_servers
   gather_facts: false
   tasks:
     - name: Get my administered identities

diff --git a/playbooks/wifi_deployment.yml b/playbooks/wifi_deployment.yml
@@ -12,7 +12,7 @@
         organizationId: '{{ org_id }}'
       register: result
     - name: Filter networks with "wireless" productTypes
-      set_fact:
+      ansible.builtin.set_fact:
         filtered_networks: '{{ result.meraki_response | selectattr(''productTypes'',
           ''contains'', ''wireless'') | list }}'
     - name: Create corporate SSID

diff --git a/plugins/modules/devices_live_tools_cable_test_info.py b/plugins/modules/devices_live_tools_cable_test_info.py
@@ -27,8 +27,7 @@
 
 
 """
-RETURN = r
-"""
+RETURN = r"""
 meraki_response:
   description: A dictionary or list with the response returned by the Cisco Meraki Python SDK
   returned: always

diff --git a/plugins/modules/devices_live_tools_throughput_test_info.py b/plugins/modules/devices_live_tools_throughput_test_info.py
@@ -27,8 +27,7 @@
 
 
 """
-RETURN = r
-"""
+RETURN = r"""
 meraki_response:
   description: A dictionary or list with the response returned by the Cisco Meraki Python SDK
   returned: always

diff --git a/plugins/modules/devices_live_tools_wake_on_lan_info.py b/plugins/modules/devices_live_tools_wake_on_lan_info.py
@@ -27,8 +27,7 @@
 
 
 """
-RETURN = r
-"""
+RETURN = r"""
 meraki_response:
   description: A dictionary or list with the response returned by the Cisco Meraki Python SDK
   returned: always

diff --git a/tests/integration/targets/meraki_ms_l3_interface/tasks/main.yml b/tests/integration/targets/meraki_ms_l3_interface/tasks/main.yml
@@ -32,7 +32,7 @@
     delegate_to: localhost
     register: query_all
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       interface_id_1: '{{ query_all.data.1.interface_id }}'
     ignore_errors: true
 
@@ -96,7 +96,7 @@
     delegate_to: localhost
     register: create
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       interface_id_1: '{{ create.data.interface_id }}'
 
   - assert:

diff --git a/tests/integration/targets/meraki_ms_stack_l3_interface/tasks/main.yml b/tests/integration/targets/meraki_ms_stack_l3_interface/tasks/main.yml
@@ -15,7 +15,7 @@
     delegate_to: localhost
     register: create_net_switch
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       net_id: '{{ create_net_switch.data.id }}'
 
   - name: Create new stack
@@ -31,7 +31,7 @@
       - "QBSB-D75G-PXCG"
     register: stack
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       stack_id: '{{ stack.data.id }}'
 
   - name: Create l3 interface with check mode
@@ -87,7 +87,7 @@
     delegate_to: localhost
     register: query_l3
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       interface_id_1: '{{ create.data.interface_id }}'
 
   - name: Query one l3 interface
@@ -200,7 +200,7 @@
   - debug:
       var: query_l3
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       interface_id_1: '{{ query_l3.data[0].interface_id }}'
     ignore_errors: true
 

diff --git a/tests/integration/targets/meraki_mx_malware/tasks/main.yml b/tests/integration/targets/meraki_mx_malware/tasks/main.yml
@@ -19,7 +19,7 @@
     delegate_to: localhost
     register: net
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       net_id: '{{ net.data.id }}'
 
   - name: Enable malware protection with check mode

diff --git a/tests/integration/targets/meraki_mx_site_to_site_vpn/tasks/main.yml b/tests/integration/targets/meraki_mx_site_to_site_vpn/tasks/main.yml
@@ -25,7 +25,7 @@
     delegate_to: localhost
     register: net_spoke
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       net_spoke_id: '{{ net_spoke.data.id }}'
       net_hub_id: '{{ net_hub.data.id }}'
 

diff --git a/tests/integration/targets/meraki_mx_static_route/meraki_static_route/tasks/main.yml b/tests/integration/targets/meraki_mx_static_route/meraki_static_route/tasks/main.yml
@@ -24,11 +24,11 @@
       vlans_enabled: true
     delegate_to: localhost
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       net_id: '{{ net.data.id }}'
 
   - name: Initialize static route id list
-    set_fact:
+    ansible.builtin.set_fact:
       route_ids: []
 
   - name: Create VLAN
@@ -55,7 +55,7 @@
     delegate_to: localhost
     register: create_route
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       route_ids: "{{ route_ids + [create_route.data.id] }}"
 
   - name: Create static_route with idempotency
@@ -86,7 +86,7 @@
     delegate_to: localhost
     register: second_create
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       route_ids: "{{ route_ids + [second_create.data.id] }}"
 
   - assert:

diff --git a/tests/integration/targets/meraki_mx_vlan/tasks/main.yml b/tests/integration/targets/meraki_mx_vlan/tasks/main.yml
@@ -19,7 +19,7 @@
     delegate_to: localhost
     register: new_net
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       test_net_id: '{{ new_net.data.id }}'
 
   - name: Enable VLANs on network

diff --git a/tests/integration/targets/meraki_network/tasks/main.yml b/tests/integration/targets/meraki_network/tasks/main.yml
@@ -58,7 +58,7 @@
     delegate_to: localhost
     register: create_net_switch
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       switch_net_id: '{{ create_net_switch.data.id }}'
 
   - name: Copy network
@@ -361,7 +361,7 @@
     delegate_to: localhost
     register: create_net_tags
 
-  - set_fact:
+  - ansible.builtin.set_fact:
       tag_net_id: '{{ create_net_tags.data.id }}'
 
   - name: Modify network by net_id