Skip to content

init commit for scheduled scaling #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@ testbin/*
*.swp
*.swo
*~

# kubebuilder
kubebuilder
9 changes: 9 additions & 0 deletions PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,13 @@ resources:
webhooks:
defaulting: true
webhookVersion: v1
- api:
crdVersion: v1
namespaced: true
controller: true
domain: mercari.com
group: autoscaling
kind: ScheduledScaling
path: github.com/mercari/tortoise/api/v1alpha1
version: v1alpha1
version: "3"
45 changes: 45 additions & 0 deletions api/v1alpha1/groupversion_info.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/*
MIT License

Copyright (c) 2023 mercari

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

*/

// Package v1alpha1 contains API Schema definitions for the autoscaling v1alpha1 API group
// +kubebuilder:object:generate=true
// +groupName=autoscaling.mercari.com
package v1alpha1

import (
"k8s.io/apimachinery/pkg/runtime/schema"
"sigs.k8s.io/controller-runtime/pkg/scheme"
)

var (
// GroupVersion is group version used to register these objects
GroupVersion = schema.GroupVersion{Group: "autoscaling.mercari.com", Version: "v1alpha1"}

// SchemeBuilder is used to add go types to the GroupVersionKind scheme
SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion}

// AddToScheme adds the types in this group-version to the given scheme.
AddToScheme = SchemeBuilder.AddToScheme
)
166 changes: 166 additions & 0 deletions api/v1alpha1/scheduledscaling_types.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,166 @@
/*
MIT License

Copyright (c) 2023 mercari

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

*/

package v1alpha1

import (
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

// EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN!
// NOTE: json tags are required. Any new fields you add must have json tags for the fields to be serialized.

// ScheduledScalingSpec defines the desired state of ScheduledScaling
type ScheduledScalingSpec struct {
// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
// Important: Run "make" to regenerate code after modifying this file

/// The schedule in Cron format, see https://en.wikipedia.org/wiki/Cron.
Schedule Schedule `json:"schedule" protobuf:"bytes,1,name=schedule"`

//TargetRef is the targets that need to be scheduled
TargetRefs TargetRefs `json:"targetRefs" protobuf:"bytes,2,name=targetRefs"`

//Currently only static, might implement others(?)
Strategy Strategy `json:"strategy" protobuf:"bytes,3,name=strategy"`
}

// ScheduledScalingStatus defines the observed state of ScheduledScaling
type ScheduledScalingStatus struct {
// INSERT ADDITIONAL STATUS FIELD - define observed state of cluster
// Important: Run "make" to regenerate code after modifying this file

//Target tortoise phase
TortoisePhase TortoisePhase `json:"tortoisePhase" protobuf:"bytes,1,name=tortoisePhase"`

//unsure if needed
ScheduledScalingPhase ScheduledScalingPhase `json:"scheduledScalingPhase" protobuf:"bytes,1,name=scheduledScalingPhase"`

// AutoscalingPolicy contains the policy how this tortoise actually scales each resource.
// It should basically be the same as .spec.autoscalingPolicy.
// But, if .spec.autoscalingPolicy is empty, tortoise manages/generates
// the policies generated based on HPA and the target deployment.
//Commenting this just in case there is a need for separate autoscaling policy in schedule
//AutoscalingPolicy []ContainerAutoscalingPolicy `json:"autoscalingPolicy,omitempty" protobuf:"bytes,6,opt,name=autoscalingPolicy"`
}

// Unsure if needed
type ScheduledScalingPhase string

type TortoisePhase string

const (
// TortoisePhaseInitializing means tortoise is just created and initializing some components (HPA and VPA),
// and wait for those components to be ready.
TortoisePhaseInitializing TortoisePhase = "Initializing"
// TortoisePhaseGatheringData means tortoise is now gathering data and cannot make the accurate recommendations.
TortoisePhaseGatheringData TortoisePhase = "GatheringData"
// TortoisePhaseWorking means tortoise is making the recommendations,
// and applying the recommendation values.
TortoisePhaseWorking TortoisePhase = "Working"
// TortoisePhasePartlyWorking means tortoise has maxReplicas and minReplicas recommendations ready,
// and applying the recommendation values.
// But, some of the resources are not scaled due to some reasons. (probably still gathering data)
TortoisePhasePartlyWorking TortoisePhase = "PartlyWorking"
// TortoisePhaseEmergency means tortoise is in the emergency mode.
TortoisePhaseEmergency TortoisePhase = "Emergency"
// TortoisePhaseBackToNormal means tortoise was in the emergency mode, and now it's coming back to the normal operation.
// During TortoisePhaseBackToNormal, the number of replicas of workloads are gradually reduced to the usual value.
TortoisePhaseBackToNormal TortoisePhase = "BackToNormal"
)

//+kubebuilder:object:root=true
//+kubebuilder:subresource:status

// ScheduledScaling is the Schema for the scheduledscalings API
type ScheduledScaling struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`

Spec ScheduledScalingSpec `json:"spec,omitempty"`
Status ScheduledScalingStatus `json:"status,omitempty"`
}

//+kubebuilder:object:root=true

// ScheduledScalingList contains a list of ScheduledScaling
type ScheduledScalingList struct {
metav1.TypeMeta `json:",inline"`
metav1.ListMeta `json:"metadata,omitempty"`
Items []ScheduledScaling `json:"items"`
Comment on lines +67 to +81
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing protobuf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobuf is missing in tortoise_types.go as well

}

type TargetRefs struct {
// ScaleTargetRef is the target of scaling.
// It should be the same as the target of HPA.
ScaleTargetRef CrossVersionObjectReference `json:"scaleTargetRef" protobuf:"bytes,1,name=scaleTargetRef"`
//Tortoise to be targeted for scheduled scaling
TortoiseName *string `json:"tortoiseName,omitempty" protobuf:"bytes,2,name=tortoiseName"`
}

// CrossVersionObjectReference contains enough information toet identify the referred resource.
type CrossVersionObjectReference struct {
// kind is the kind of the referent; More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
Kind string `json:"kind" protobuf:"bytes,1,opt,name=kind"`

// name is the name of the referent; More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
Name string `json:"name" protobuf:"bytes,2,opt,name=name"`

// apiVersion is the API version of the referent
// +optional
APIVersion string `json:"apiVersion,omitempty" protobuf:"bytes,3,opt,name=apiVersion"`
}

type Schedule struct {
/// The schedule in Cron format, see https://en.wikipedia.org/wiki/Cron.
//start of schedule
StartAt string `json:"startAt" protobuf:"bytes,1,name=startAt"`
//end of schedule
FinishAt string `json:"finishAt" protobuf:"bytes,2,name=finishAt"`
}

type Strategy struct {
//Resource scaling requirements
Static Static `json:"static" protobuf: "bytes,1,name=static"`
}

type Static struct {
//Min replicas to be deployed on schedule
MinReplicas int `json:"minReplica" protobuf:"bytes,1,name=minReplica"`
//Resources requested per container
MinAllocatedResources []ContainerResourceRequests `json:"minAllocatedResources" protobuf:"bytes,2,name=minAllocatedResources"`
}

// Not sure if I need this here, duplicated code from tortoise types
type ContainerResourceRequests struct {
// ContainerName is the name of target container.
ContainerName string `json:"containerName" protobuf:"bytes,1,name=containerName"`
Resource v1.ResourceList `json:"resource" protobuf:"bytes,2,name=resource"`
}

func init() {
SchemeBuilder.Register(&ScheduledScaling{}, &ScheduledScalingList{})
}
123 changes: 123 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading