Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extendSchema): throw if federationMetadata is enabled #349

Merged
merged 3 commits into from
Nov 13, 2020
Merged

fix(extendSchema): throw if federationMetadata is enabled #349

merged 3 commits into from
Nov 13, 2020

Conversation

PacoDu
Copy link
Contributor

@PacoDu PacoDu commented Nov 13, 2020

1 step to address the issue #348

This PR prevent the usage of extendSchema if federationMedata is enabled

@PacoDu PacoDu requested a review from mcollina November 13, 2020 09:42
mcollina
mcollina approved these changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d5e5df9 into mercurius-js:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PacoDu @mcollina