Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): remove redundant locale prop in Calendar #1615

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

ZeekoZhu
Copy link
Contributor

@ZeekoZhu ZeekoZhu commented Feb 12, 2025

Calendar 添加的 locale Prop 是多余的,因为 DatesProvider 已经在 dashboard-render/editor 上添加了。另外,这里的 locale 也没有被 lang2dayjsLocale 处理,跟 DatesProvider 的行为不一致。

修复后,Calendar 将采用 dashboard-render/editor 配置的 DatesProvider locale:
image
image

@ZeekoZhu ZeekoZhu requested a review from GerilLeto February 14, 2025 07:14
@GerilLeto GerilLeto force-pushed the date-picker-use-dates-provider-config branch from 5b8b709 to c44a17a Compare February 17, 2025 10:15
@GerilLeto GerilLeto merged commit 0b62437 into main Feb 17, 2025
1 check passed
@GerilLeto GerilLeto deleted the date-picker-use-dates-provider-config branch February 17, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants