Improve error handling #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukipuki
force-pushed
the
error-handling
branch
2 times, most recently
from
1d53d77 to
8d68e52
Compare
Propagate errors in the handlers. The errors are now caught in the `disconnect` function but we should work towards notifying the user even sooner. This is an improvement though, as previously the user hasn't been notified at all.
lukipuki
force-pushed
the
error-handling
branch
from
8d68e52 to
8e7fa0c
Compare
ajmcquilkin
reviewed
Jan 23, 2024
| // Note: we only return the first error. | ||
| read_result??; | ||
| write_result??; | ||
| processing_result??; |
There was a problem hiding this comment.
Is the ?? something the user will need to do regularly? This feels like an annoying pattern
There was a problem hiding this comment.
This is an internal function and we can certainly make it nicer in a public interface, but I haven't finalized my thoughts on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error handling
Propagate errors in the handlers. The errors are now caught in the
disconnectfunction but we should work towards notifying the user even sooner.This is an improvement though, as previously the user hasn't been notified at all.